-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update command palette design #514
Conversation
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 81.65% 81.78% +0.12%
==========================================
Files 213 216 +3
Lines 12098 12084 -14
Branches 1179 1197 +18
==========================================
+ Hits 9879 9883 +4
+ Misses 2205 2187 -18
Partials 14 14
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
@sehyod I think we should add .command-palette .info_wrapper > svg {
@apply h-6 w-6 fill-btn-ico-modal-item-default p-[0.25rem];
}
EDIT: I think that the root cause for this is that the size (box model) for icons from react-icons and the SVGs (we can use alongside with icons) "don't match the css rules". |
Yes, this works. I did not update it because I thought we would use custom icons soon, but the design team confrimed we should use the icons from react-icons, so I will update the CSS rules EDIT: Actually I don't think we need the padding, the height and width are enough. The custom icons have a size of 24x24px so we can use the same for react-icons for consistency |
This implements the new design for the command palette.
This hides actions depending on the context. The test file has been updated to reflect this change and make it easier to grow the component by adding new actions
Closes #439