Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consider auto save for documents #556

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Sep 19, 2023

Auto-save documents

  • remove dirty indicator from tab
  • create utility hook to check if any file is dirty
  • debounced save of editor content after update
  • footer item indicator
auto-save.mov

This is related to #484

- remove dirty indicator from tab
- create utility hook to check if any file is dirty
- debunced save of editor content after update
- footer item indicator
@cguedes cguedes linked an issue Sep 19, 2023 that may be closed by this pull request
@cguedes cguedes requested a review from sehyod September 19, 2023 18:39
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #556 (aa01959) into main (7985127) will decrease coverage by 3.84%.
Report is 2 commits behind head on main.
The diff coverage is 82.41%.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   80.96%   77.12%   -3.84%     
==========================================
  Files         221      230       +9     
  Lines       13052    14172    +1120     
  Branches     1242     1287      +45     
==========================================
+ Hits        10567    10930     +363     
- Misses       2470     3224     +754     
- Partials       15       18       +3     
Files Changed Coverage Δ
src/atoms/core/createEditorContentAtoms.ts 82.02% <48.38%> (-17.98%) ⬇️
src/atoms/hooks/useAnyEditorDataIsDirty.ts 100.00% <100.00%> (ø)
src/components/TabPane.tsx 100.00% <100.00%> (ø)
src/components/footer/Footer.tsx 100.00% <100.00%> (ø)
...atures/textEditor/footer/FooterSavingFilesItem.tsx 100.00% <100.00%> (ø)
src/test/test-utils.tsx 98.13% <100.00%> (+0.01%) ⬆️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes marked this pull request as ready for review September 20, 2023 10:10
@cguedes cguedes requested a review from sehyod September 20, 2023 10:10
src/test/test-utils.tsx Outdated Show resolved Hide resolved
@cguedes cguedes merged commit aa1e5f6 into main Sep 20, 2023
10 of 11 checks passed
@cguedes cguedes deleted the 484-consider-auto-save-for-documents branch September 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider auto-save for documents
2 participants