Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflows #63

Merged
merged 26 commits into from
Jun 2, 2023
Merged

ci: add workflows #63

merged 26 commits into from
Jun 2, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented May 30, 2023

Fixes #10

- name: Setup Python
uses: ./.github/actions/setup-python
- name: PyTest
run: poetry run pytest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sehyod @sergioramos Let's change this line to look only in the test directory for now. It shouldn't matter here, but if you run this line as is in our repo, pytest picks up a lot of other things that aren't truly tests.

Suggested change
run: poetry run pytest
run: poetry run pytest python/tests

I tried to push a change up to test this, but I don't have workflow scope on the repo.

 ! [remote rejected] initial-ci-cd -> initial-ci-cd (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/on-push.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/refstudio/refstudio'

Comment on lines 15 to 16
- id: cached-poetry-dependencies
uses: actions/cache@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try removing the cache until we get a full workflow running properly, and then we can add it back in.

@gjreda
Copy link
Collaborator

gjreda commented Jun 1, 2023

@sehyod @sergioramos Looking at the logs from this workflow, it does not seem like the Python dependencies are being installed via poetry. Is there a way to verify?

I'd expect there to be some install dialog in the section below. Maybe something with the dependency caching we are using?

image

@sehyod
Copy link
Collaborator Author

sehyod commented Jun 2, 2023

@gjreda Thank you for looking into this issue! I have pushed the changes you suggested and added the verbosity option to poetry install to see what is going on. From the new logs, I think dependencies are indeed installed by poetry

@sergioramos sergioramos force-pushed the initial-ci-cd branch 2 times, most recently from 1b302d7 to 1cbe2d0 Compare June 2, 2023 22:25
sergioramos pushed a commit that referenced this pull request Jun 2, 2023
references #50 

This is a potentially temporary as it allows us to move forward with #63
@sergioramos sergioramos marked this pull request as ready for review June 2, 2023 22:38
@sergioramos sergioramos changed the title Add ci-cd workflows ci: add workflows Jun 2, 2023
@sergioramos sergioramos merged commit 4f4e7c7 into main Jun 2, 2023
7 checks passed
@sergioramos sergioramos deleted the initial-ci-cd branch June 2, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD plans
3 participants