Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove embedding creation from pdf ingestion #83

Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix: remove embedding creation from pdf ingestion #83

merged 3 commits into from
Jun 2, 2023

Conversation

gjreda
Copy link
Collaborator

@gjreda gjreda commented Jun 2, 2023

Fixes #50

@gjreda gjreda requested review from cguedes and sehyod June 2, 2023 17:43
@gjreda gjreda marked this pull request as ready for review June 2, 2023 17:43
@gjreda
Copy link
Collaborator Author

gjreda commented Jun 2, 2023

@sehyod I think this should resolve the issues you're seeing in #63. I think it'd be good to get CI/CD working properly and then I can worry about adding this back in later, since we do not need it right now.

@gjreda gjreda mentioned this pull request Jun 2, 2023
Closed
@sergioramos sergioramos force-pushed the 50-remove-embedding-creation-from-pdf-ingestion branch from ce4b152 to 94c3bcf Compare June 2, 2023 22:29
@sergioramos sergioramos changed the title Remove embedding creation from pdf ingestion (#50) fix: remove embedding creation from pdf ingestion Jun 2, 2023
@sergioramos sergioramos merged commit 8428397 into main Jun 2, 2023
@sergioramos sergioramos deleted the 50-remove-embedding-creation-from-pdf-ingestion branch June 2, 2023 22:35
@gjreda gjreda mentioned this pull request Jun 6, 2023
Closed
gjreda added a commit that referenced this pull request Jun 6, 2023
@gjreda
This should have been included in #83
04a0eda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguedes cguedes Awaiting requested review from cguedes

@sehyod sehyod Awaiting requested review from sehyod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove embedding creation from PDF ingestion
2 participants
@gjreda @sergioramos