AgentMeta and Prototype Registry refactor #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal for unit testing
jcowman2
commented
Aug 29, 2019
| const am = this.getAgentManager(agent.meta.id); | ||
|
|
||
| if (protoId !== undefined) { | ||
| if (am === undefined || am.meta.protoId !== undefined) { |
There was a problem hiding this comment.
Does this ever fail?
Pull Request Test Coverage Report for Build 378
💛 - Coveralls |
jcowman2
commented
Sep 9, 2019
jcowman2
commented
Sep 9, 2019
src/common/impl/pk-provider-impl.ts
Outdated
| @@ -112,11 +112,21 @@ export class PKProviderImpl<PKClass> implements PKProvider<PKClass> { | |||
| return this.lastPK.index(); | |||
| } | |||
|
|
|||
| public forkAfterKey(key: PK<PKClass> | FK<PKClass>): PKProvider<PKClass> { | |||
| public forkAfterKey( | |||
| key: PK<PKClass> | FK<PK<PKClass>> | |||
There was a problem hiding this comment.
Can this signature be condensed to PK<PKClass>
This was possible because FK extends PK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AgentmetadataChecklist
Change Type
Is this a breaking change?
If yes, describe what exactly this change breaks:
Replaces
Agent.idwithAgent.meta.Unit Tests
Documentation
Related Issues