Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: README.rst doctest failed after 5.1 release #86

Closed
hosiet opened this issue May 11, 2022 · 1 comment · Fixed by #93
Closed

Regression: README.rst doctest failed after 5.1 release #86

hosiet opened this issue May 11, 2022 · 1 comment · Fixed by #93

Comments

@hosiet
Copy link

hosiet commented May 11, 2022

Doctest on README.rst fails after 5.1 release. The regression was introduced by commit 1fc899d .

Regression behavior:

$ git checkout 1fc899d46d02da08cdc113139a9cd44ba8901a65
Previous HEAD position was 448b381 Refactor to better preserve the original path (#80)
HEAD is now at 1fc899d Added Abstract Base Classes (#82)
$ ./test.py
M 200,100 L 300,100 Q 200,200 200,300
$ git checkout 448b3812554a723f29592ff54712fd490e8729ad
Previous HEAD position was 1fc899d Added Abstract Base Classes (#82)
HEAD is now at 448b381 Refactor to better preserve the original path (#80)
$ ./test.py
L 300,100 Q 200,200 200,300
$ cat ./test.py
#!/usr/bin/python3

from svg.path import Path, Line, Arc, CubicBezier, QuadraticBezier, Close
path = Path(Line(100+100j,300+100j), Line(100+100j,300+100j))
path.append(QuadraticBezier(300+100j, 200+200j, 200+300j))
path[0] = Line(200+100j,300+100j)
del path[1]
print(path.d())
regebro added a commit that referenced this issue Jun 11, 2022
@regebro
Copy link
Owner

regebro commented Jun 11, 2022

Ah, when switching to pytest this wasn't run any more, didn't notice that.

regebro added a commit that referenced this issue Jun 11, 2022
regebro added a commit that referenced this issue Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants