Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Implement voting #56

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Implement voting #56

merged 3 commits into from
Apr 2, 2020

Conversation

alpe
Copy link
Collaborator

@alpe alpe commented Mar 18, 2020

After #55

With every vote the status of the proposal is updated. In case the decision policy returns a final result the proposal result is set and it can be executed via MsgExec before the timeout.

Resolves #47

@alpe alpe changed the base branch from create_proposal_base to threshold_decision_policy March 18, 2020 14:23
@alpe alpe requested a review from aaronc March 18, 2020 14:23
@alpe alpe force-pushed the threshold_decision_policy branch from 30580b3 to a71fa09 Compare March 30, 2020 07:40
@alpe alpe mentioned this pull request Mar 30, 2020
@alpe alpe force-pushed the threshold_decision_policy branch from a71fa09 to a15dcc9 Compare March 30, 2020 09:43
incubator/group/keeper_test.go Outdated Show resolved Hide resolved
incubator/group/keeper_test.go Show resolved Hide resolved
incubator/group/keeper_test.go Show resolved Hide resolved
incubator/group/types.go Outdated Show resolved Hide resolved
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we create an issue to track proposals not being invalidated when Comment or Admin change. Otherwise LGTM.

incubator/group/keeper_test.go Show resolved Hide resolved
@alpe
Copy link
Collaborator Author

alpe commented Apr 2, 2020

Waiting for approval on #55 to merge

@aaronc aaronc merged commit 49967b2 into threshold_decision_policy Apr 2, 2020
@alpe alpe mentioned this pull request Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants