Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add remove allowed denom gov message #1346

Merged
merged 13 commits into from
Aug 15, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 11, 2022

Description

Ref: #729


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1346 (7b4c9ea) into master (9aef28b) will decrease coverage by 0.24%.
The diff coverage is 69.56%.

❗ Current head 7b4c9ea differs from pull request most recent head be7d074. Consider uploading reports for the commit be7d074 to get more accurate results

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
- Coverage   77.36%   77.11%   -0.25%     
==========================================
  Files         211      215       +4     
  Lines       15395    15465      +70     
==========================================
+ Hits        11910    11926      +16     
- Misses       2582     2629      +47     
- Partials      903      910       +7     
Impacted Files Coverage Δ
.../ecocredit/marketplace/msg_remove_allowed_denom.go 50.00% <50.00%> (ø)
...dit/server/marketplace/msg_remove_allowed_denom.go 77.77% <77.77%> (ø)
x/ecocredit/marketplace/codec.go 100.00% <100.00%> (ø)
x/ecocredit/server/marketplace/keeper.go 100.00% <100.00%> (ø)
x/ecocredit/server/server.go 73.91% <100.00%> (ø)
app/app.go 73.14% <0.00%> (-0.42%) ⬇️
...credit/server/marketplace/msg_add_allowed_denom.go
x/ecocredit/marketplace/msg_add_allowed_denom.go
... and 5 more

@aleem1314 aleem1314 marked this pull request as ready for review August 12, 2022 10:51
@aleem1314 aleem1314 requested a review from a team August 12, 2022 10:51
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aleem1314 and others added 5 commits August 15, 2022 17:56
…om.feature

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
…om.feature

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
…om.feature

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 nit

ryanchristo and others added 2 commits August 15, 2022 14:52
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
@ryanchristo ryanchristo changed the title feat(marketplace): add remove allowed denom gov message feat(x/ecocredit): add remove allowed denom gov message Aug 15, 2022
@ryanchristo ryanchristo merged commit 2dccef4 into master Aug 15, 2022
@ryanchristo ryanchristo deleted the aleem/remove-allowed-denom branch August 15, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants