-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-194 add prev/next post functionality #2398
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9149650
to
150ff17
Compare
@erikalogie see testing instructions |
When I'm on this page and click the "back" button I get this error |
Looks like the post has been deleted since you tested so I get 404. I've identified somewhere in the code that could fix this. Could you test again with some other posts? |
33b92b0
to
2632ce6
Compare
I'm noticing a few things:
|
Fixed.
This will require a fix at the server side I believe, will let you know once that's done.
How do you know the post has been deleted? The fact that it doesn't appear on the timeline is because I've changed our API and we need to merge #2409 first for the timeline to work normally. |
Ready to test |
LGTM |
Just tested this and seems to work correctly |
One new issue I did spot in testing just now on this project's data stream: https://deploy-preview-2398--regen-marketplace.netlify.app/project/kasigau, is that you can click previous and go to posts that do not appear on the data stream itself. Sending you a video via slack as it is not uploading to github. |
2e2edad
to
e5abcb3
Compare
@erikalogie could you test this again? |
Working now! LGTM |
e5abcb3
to
9392e80
Compare
Description
https://regennetwork.atlassian.net/browse/APP-194?atlOrigin=eyJpIjoiNzM5NzkzNmI1M2VkNDI2Zjg0ZjFmZDA1YjE1MWIxNmUiLCJwIjoiaiJ9
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
https://deploy-preview-2398--regen-marketplace.netlify.app
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...