This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Fix interval initial state and data type change #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I am seeing you are getting familiar with the lib :) |
borisyankov
pushed a commit
that referenced
this pull request
Jan 20, 2017
* Add RSI indicator - Set yAxis heights dynamically - Add vim swap files to gitignore - Generalize rsi logic for all indicators with yAxis - Add top padding to the indicator y axis - Create IndicatorsWithYAxis config * Allow interval change for line/area Add DynamicTimeInterval story for testing Add DataType for more granular line/area chart Set default dataType to candles Read close when converting ohlc to ticks * Fix interval initial state and data type change (#176) * Add MACD - Update binary-indicators version - 9.2.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataTypein binarycharts was redundant, we could mappedintervaltodataTypeintervalhad to match initialticks, therefore added new propintervalwhich is needed in case of candles e.g.interval="60"