Show an error if an empty sheet is selected #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we should show all of the sheets available in the sheet selector (to avoid confusion) we may end up in a situation where a user selects an empty sheet. Previously, we just crashed with a bad range when this happened, but now we instead show the user an error explaining that they need to choose a non-empty sheet.
rossjones
requested review from
simonwo and
alaric-rd
and removed request for
simonwo
simonwo
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we should show all of the sheets available in the sheet selector (to avoid confusion) we may end up in a situation where a user selects an empty sheet. Previously, we just crashed with a bad range when this happened, but now we instead show the user an error explaining that they need to choose a non-empty sheet.