Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-spams gets incorrect PR updates #476

Closed
jakirkham opened this issue Mar 13, 2019 · 7 comments · Fixed by #488
Closed

python-spams gets incorrect PR updates #476

jakirkham opened this issue Mar 13, 2019 · 7 comments · Fixed by #488

Comments

@jakirkham
Copy link
Contributor

We have had a few update PRs at python-spams that have been completely incorrect. For example they show major version bumps (with minor and patch release bumps included) that have not happened. Not entirely sure why this is, but am raising it here.

xref: conda-forge/python-spams-feedstock#27
xref: conda-forge/python-spams-feedstock#28
xref: conda-forge/python-spams-feedstock#38

@CJ-Wright
Copy link
Member

Hmm that is odd, maybe this is one of those places where it will respond affirmatively to any version number we ask for?

@jakirkham
Copy link
Contributor Author

Maybe. Though how do we decide to request something like 4.1.2 instead of say 4.0.0?

@CJ-Wright
Copy link
Member

CJ-Wright commented Mar 13, 2019

I think the code for that is here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/update_upstream_versions.py#L32

My understanding of this is that we keep asking for version numbers until we either hit a null or have asked for 10 things.

@jakirkham
Copy link
Contributor Author

jakirkham commented Apr 15, 2019

Would it be possible to simply remove python-spams from the auto-tick bot? It seems to be getting this wrong more often than right unfortunately.

ref: conda-forge/python-spams-feedstock#40
ref: conda-forge/python-spams-feedstock#41
ref: conda-forge/python-spams-feedstock#42
ref: conda-forge/python-spams-feedstock#43
ref: conda-forge/python-spams-feedstock#44
ref: conda-forge/python-spams-feedstock#45
ref: conda-forge/python-spams-feedstock#46
ref: conda-forge/python-spams-feedstock#47

@scopatz
Copy link
Contributor

scopatz commented May 29, 2019

There was talk of being able to have packages blacklist themselves. I am not sure we ever implemented it, though

@jakirkham
Copy link
Contributor Author

Do you know where that discussion was?

@scopatz
Copy link
Contributor

scopatz commented Jun 3, 2019

It was just between @CJ-Wright and myself. I don't think we wrote anything semi-formal down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants