ENH: Add Activity for Travis CI #107
Conversation
rever/activities/travis_ci.xsh
Outdated
| - conda update conda | ||
|
|
||
| # Install dependencies | ||
| - conda install {conda_deps} -c (conda_channels) |
There was a problem hiding this comment.
Maybe also add a {conda_extra} so that users can add extra stuff to their conda install.
There was a problem hiding this comment.
What would be the environmental variable that determines that? Since the $DOCKER_CONDA_DEPS is an array wouldn't the user already add whatever they wanted to install into here?
There was a problem hiding this comment.
Yeah, so I am suggesting something a little more sophisticated. Basically we could add new global env vars CONDA_DEPS, APT_DEPS, PIP_DEPS, etc. and then if DOCKER_*_DEPS or the TRAVIS_*_DEPS are not found, they fall back to the value set in the global env vars.
There was a problem hiding this comment.
You could make an env var if you wanted. It might be better to separate those since you might be interested in the deps for something else.
rever/activities/travis_ci.xsh
Outdated
| """ | ||
|
|
||
| class TravisCI(Activity): | ||
| """Manages keeping a changelog up-to-date. |
There was a problem hiding this comment.
Need to change docs over to TravisCI.
rever/activities/travis_ci.xsh
Outdated
|
|
||
| # script: | ||
| # - set -e | ||
| # - # Command to build your docs |
There was a problem hiding this comment.
Pull test command from the Nose or Pytest activities.
rever/activities/travis_ci.xsh
Outdated
| # script: | ||
| # - set -e | ||
| # - # Command to build your docs | ||
| # - pip install doctr |
There was a problem hiding this comment.
We may want to remove doctr from this for now, although it would be nice to have a doctr setup activity which we could depend on.
|
|
||
| matrix: | ||
| include: | ||
| - python: 3.6 |
There was a problem hiding this comment.
@scopatz any suggestions on how to handle the different python versions?
rever/activities/travis_ci.xsh
Outdated
| super().__init__(name='changelog', deps=deps, | ||
| desc="Manages keeping a changelog up-to-date.", | ||
| setup=self.setup_func) | ||
| self._re_cache = {} |
rever/activities/travis_ci.xsh
Outdated
|
|
||
| def __init__(self, *, deps=frozenset()): | ||
| super().__init__(name='changelog', deps=deps, | ||
| desc="Manages keeping a changelog up-to-date.", |
rever/activities/travis_ci.xsh
Outdated
|
|
||
|
|
||
| def setup_func(self): | ||
| """Initializes the changelog activity by starting a news dir, making |
rever/activities/travis_ci.xsh
Outdated
| pip_deps=$DOCKER_PIP_DEPS, | ||
| conda_channels=$DOCKER_CONDA_CHANNELS) | ||
| f.write(s) | ||
| return True |
|
Thanks for putting this in @Sasaank! |
rever/activities/travis_ci.xsh
Outdated
| @@ -0,0 +1,99 @@ | |||
| """Activity for keeping a changelog from news entries.""" | |||
There was a problem hiding this comment.
Docstring should be updated.
| notifications: | ||
| email: false | ||
|
|
||
| """ |
There was a problem hiding this comment.
I don't think that this is anywhere near general enough. There is nothing in rever that states the project has to be python oriented. I suggest taking a look at how the Docker containers are built. Basically the user provides depenendcy lists (for different potential package managers) and an install command / script. For CI, we'd want a test line/script as well. You may also want a flag for enabling doctr, since that seems to be here too.
There was a problem hiding this comment.
Hmm, that's fair (I was the one doing the copy-paste from rever's travis).
rever/activities/travis_ci.xsh
Outdated
| in the current environment. | ||
| :$CHANGELOG_TEMPLATE: str, filename of the template file in the | ||
| news directory. The default is ``'TEMPLATE'``. | ||
| """ |
First pass at Travis more to come.
Closes #106