Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple protocols refactor #13

Merged
merged 15 commits into from
Mar 13, 2024
Merged

Multiple protocols refactor #13

merged 15 commits into from
Mar 13, 2024

Conversation

rogermiranda1000
Copy link
Collaborator

@rogermiranda1000 rogermiranda1000 commented Mar 13, 2024 •
edited
Loading

What is new

  • Now the module will check if you're running Streaming Assistant, Business Streaming, or PICO Connect.
  • Now the module will check for the mergetype value (under PICO Connect config) and give an info message telling the user to change this value to 2 (temporal fix while we're working on).
  • Added unit tests to check the connector builder and the config reader.

Tests

  • All unit tests passes
  • Ran manual tests:
    • Streaming Assistant v9.6.99 was detected by the module, and it was sending blendshapes values (validated on a compatible VRChat avatar)
    • Business Streaming v1.1.0.1 was detected by the module, and it was sending blendshapes values (validated on a compatible VRChat avatar)
    • PICO Connect v10.0.23 was detected by the module
    • PICO Connect v10.0.23 with mergetype=2 was detected by the module, and it was sending blendshapes values (validated on a compatible VRChat avatar)
    • After closing PICO Connect, VRCFT program didn't crash

rogermiranda1000 and others added 15 commits January 28, 2024 17:38
@rogermiranda1000
Namespace refactor
4e32f77
@rogermiranda1000
Refactored pico packet listening
00f5387
@rogermiranda1000
Fix: detect software
0b32346
@rogermiranda1000
Unit tests: ConnectorFactory
9c19373
@rogermiranda1000
Deleted TCPHelper (method of old branch); Unit tests: check PICO Conn…
8ba5e07 
…ect config 1/2; Feature: instantiate legacy connector depending on PICO Connect config 1/2
@rogermiranda1000
Feature: instantiate legacy connector depending on PICO Connect confi…
d9fa317 
…g 1/2
@lonelyicer @rogermiranda1000
Add Pico Connect Protocol Version Auto Detect
22737cd
@lonelyicer @rogermiranda1000
Renamed File
bc3f7f5
@rogermiranda1000
Feature: check transfer protocol; Unit tests: check json read 1/2
29afa45
@rogermiranda1000
Unit tests: check json read
6f90526
@rogermiranda1000
Feature: removed external dependency
1d924c8
@rogermiranda1000
Fix: infinite loop
330c3ef
@rogermiranda1000
Fix: constant crash after closing app
d3ddbdc
@rogermiranda1000
Fix: unit tests logger
2cb7e02
@rogermiranda1000
Merge pull request #5 from rogermiranda1000/multiple-protocols-refactor
671e8f6 
Multiple protocols refactor
@rogermiranda1000 rogermiranda1000 added the enhancement New feature or request label Mar 13, 2024
@rogermiranda1000 rogermiranda1000 merged commit e3a3239 into regzo2:vrcfacetracking-module Mar 13, 2024
@rogermiranda1000
Copy link
Collaborator Author

In theory this PR serves the same purpose as #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rogermiranda1000 @lonelyicer