rehype-minify-url: fix link[rel=canonical]

Previously the `[href]` of a `link[rel=canonical]` was minified. It shouldn’t be.
rehypejs · Sep 11, 2021 · 190ced9 · 190ced9
1 parent 28a3f72
commit 190ced9
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/packages/rehype-minify-url/index.js b/packages/rehype-minify-url/index.js
@@ -70,7 +70,13 @@ export default function rehypeMinifyUrl(options) {
         if (
           hasProperty(node, prop) &&
           own.call(urlAttributes, prop) &&
-          isElement(node, urlAttributes[prop])
+          isElement(node, urlAttributes[prop]) &&
+          !(
+            node.tagName === 'link' &&
+            prop === 'href' &&
+            Array.isArray(props.rel) &&
+            props.rel.includes('canonical')
+          )
         ) {
           props[prop] = minify(props[prop], relate)
         }

diff --git a/packages/rehype-minify-url/test.js b/packages/rehype-minify-url/test.js
@@ -87,6 +87,29 @@ test('rehype-minify-url', (t) => {
     u('root', [{type: 'element', tagName: 'a', children: []}])
   )
 
+  t.deepEqual(
+    rehype()
+      .use(min, options)
+      .runSync(
+        u('root', [
+          {
+            type: 'element',
+            tagName: 'link',
+            properties: {href: options.from, rel: ['canonical']},
+            children: []
+          }
+        ])
+      ),
+    u('root', [
+      {
+        type: 'element',
+        tagName: 'link',
+        properties: {href: options.from, rel: ['canonical']},
+        children: []
+      }
+    ])
+  )
+
   t.deepEqual(
     rehype()
       .use(() => (_, file) => {