New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passNode
option to pass props.node
#22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ChristianMurphy
added
☂️ area/types
This affects typings
🗄 area/interface
This affects the public interface
🦋 type/enhancement
This is great to have
🧒 semver/minor
This is backwards-compatible change
labels
Jul 22, 2020
wooorm
reviewed
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
@ChristianMurphy Can you confirm on the types?
ChristianMurphy
approved these changes
Jul 24, 2020
wooorm
approved these changes
Jul 24, 2020
Thanks @Rokt33r, released in 6.1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🗄 area/interface
This affects the public interface
☂️ area/types
This affects typings
💪 phase/solved
Post is done
🧒 semver/minor
This is backwards-compatible change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
And I added a type alias,
ComponentProps
because I found that type inference for component's props argument doesn't work. So adopters who want to access props, they have to setComponentProps
manually.So I need to fix like