-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rehype-class-names
to list of plugins
#146
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 461 461
=========================================
Hits 461 461 ☔ View full report in Codecov by Sentry. |
rehype-add-classes is abandoned; see martypdx/rehype-add-classes#2. rehype-class-names is a fork that has the `npm audit` issues fixed.
389bfc9
to
ef8c998
Compare
I'd suggest holding off on this change until riderjensen/rehype-class-names#1 is fixed. |
Just wanted to chime in here, very nice to be thought of for being added to the plugins here. Just so you know @wooorm I just updated to v1.0.13 which now uses |
@riderjensen Nice, awesome! For the types, I think you could use import {Root} from 'hast'
import {Conditional} from 'hast-util-classnames'
import {Plugin} from 'unified'
export interface Options {
[selector: string]: Conditional
}
declare const rehypeClassNames: Plugin<[(Options | null | undefined)?], Root>
export default rehypeClassNames |
rehype-class-names
to list of plugins
This comment has been minimized.
This comment has been minimized.
Thank y’all! ✨ |
Initial checklist
Description of changes
rehype-add-classes is abandoned; see martypdx/rehype-add-classes#2. rehype-class-names is a fork that has the
npm audit
issues fixed.