Resolves #1466 #1534
Resolves #1466 #1534
Conversation
Update hub
Update hub
In RMD added is_forecast_query = TRUE
ydhuang28
changed the title
There was a problem hiding this comment.
Looks good! One minor suggestion, I think with this change, the default target chosen when you load the viz is inc cases, this is because the default target is set to the last one (size_of_seasons-1) when loaded, could you change that to the Cumulatve deaths target? It's in Chloropeth.vue#ready() function. Otherwise this looks good to me and let's get this merged! 👍
| @@ -68,6 +68,12 @@ exports.targetFullNameCum = { | |||
| '3-ahead': '3 wk ahead cum death', | |||
| '4-ahead': '4 wk ahead cum death' | |||
| }; | |||
| exports.targetFullNameIncCase = { | |||
There was a problem hiding this comment.
Is this variable used anywhere?
There was a problem hiding this comment.
Yep, it's used here to pick out the incident case data from the filtered CSV files. For some reason GitHub doesn't expand the diff automatically...
There was a problem hiding this comment.
Maybe because it has csv in the filename?
Add weekly report for 2020922 and update rmd
|
Is @hannanabdul55 's comment above about which of the forecasted targets are loaded when the page first loads? if so, I might prefer to have this load the incident deaths by default instead of cumulative deaths. minor point, and may warrant an issue of it's own? |
|
@nickreich I think this is straightforward to do here itself. Then it is even easier, just load the season in the above mentioned function to |
|
Hmm. I had the same idea and tried that, but apparently the data won't load on start-up if I update the selected target to |
|
I'll keep working on this in the mean time. |
|
@ydhuang28 yeah, this seems like a weird behavior. I think it is because of the season download data that happens at load just download only the last one? I am not sure exactly what's going on there. Will need to dig into that more. But I think that is not a big issue right now and could be tracked in another Github issue itself and in the meantime, we could maybe merge this? I am fine with either way. |
|
Yep, we can merge this. I'll open a separate issue for the data loading problem. |
|
I've created a new issue for showing the correct default target: Issue #1536 |
Description
Incident cases forecasts can now be seen on the visualization.