New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forecast versioning #273
Labels
Comments
Looks great, Matt! I think it'd be nice for the web ui to show all versions where feasible (e.g. in tables) but maybe to choose the most recent where not feasible (e.g. in the forecast summary visualization) |
Agreed. I scoped out as many web ui changes like this that I could think of, including:
I know we will notice others as I code along. |
perfect! |
matthewcornell
added a commit
that referenced
this issue
Nov 10, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 12, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 16, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 16, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 16, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 16, 2020
matthewcornell
added a commit
that referenced
this issue
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Google doc from discussion: https://docs.google.com/document/d/18BJaMxqEsNl1BzKwm_vx8RV0bVITJJHeG3hgTm61fWc/edit
Many changes required, e.g.,
Forecast.issue_date
DateField, which defaults todate(Forecast.created_at)
(i.e., the timestamp when Zoltar created the Forecast).date(Forecast.created_at)
. backup first!Forecast.issue_date
.Forecast.issue_date
, for reasons of scientific integrity. All other creation uses the default as above. (Q: What is our permission policy? Django staff users? Django admin?as_of
key. If not passed then it defaults to using the most recent version. In the future we may add a second new optional field namedissue_date
that causes the query to only include Forecast with that date. This differs fromas_of
- as @nickreich puts it:forecast_date
For any
as_of
query discussions: Here's an example database with versions (header is timezeros, rows are forecast version dates):Here are some
as_of
examples (which forecast version would be used as of that date):The text was updated successfully, but these errors were encountered: