Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "opening triangle" #27

Closed
matthewcornell opened this issue Dec 7, 2023 · 1 comment
Closed

remove "opening triangle" #27

matthewcornell opened this issue Dec 7, 2023 · 1 comment

Comments

@matthewcornell
Copy link
Member

matthewcornell commented Dec 7, 2023

From this Slack thread, @elray1 says:

it would probably be easiest to turn off what Aaron has termed the “opening triangle” that is created by connecting the forecasts to the last observed data point. This would involve removing state.as_of_truth.date.slice(-1).concat( from these lines.

@nickreich's comment:

the opening triangle issue .. is currently creating some very weird shapes for the models that have some “-1” horizons [see image below]

In the future we might add an App.initialize() option to control it.

image

@nickreich
Copy link
Member

Unfortunately, I think the update didn't fix all of this. It removed the "opening triangle" but not the line connecting the end of the data with the start of the forecasts. See this screenshot.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants