Skip to content

Commit

Permalink
bind session and make defensive copy of sublist
Browse files Browse the repository at this point in the history
  • Loading branch information
reiern70 committed Nov 26, 2014
1 parent 74924af commit 91bc263
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bgprocess/src/main/java/com/antilia/BgProcessSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public BgProcessSession(Request request) {
super(request);
}

public void add(ExecutionBridge bridge) {
public synchronized void add(ExecutionBridge bridge) {
bind();
bridges.add(bridge);
}

Expand All @@ -39,8 +40,7 @@ public synchronized void pruneFinishedTasks() {

public Iterator<ExecutionBridge> getTasksPage(int start, int size) {
int min = Math.min(size, bridges.size());
// mgrigorov: maybe make a copy of the subList to avoid ConcurrentModificationExceptions ?!
return bridges.subList(start, min).iterator();
return new ArrayList<ExecutionBridge>(bridges.subList(start, min)).iterator();
}

public long countTasks() {
Expand Down

0 comments on commit 91bc263

Please sign in to comment.