Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiDPI display errors on Windows 10 #101

Closed
quigleyj97 opened this issue Jul 14, 2019 · 2 comments
Closed

HiDPI display errors on Windows 10 #101

quigleyj97 opened this issue Jul 14, 2019 · 2 comments
Labels
bug Something isn't working staging Code for this issue is on staging ui For issues related to the UI
Milestone

Comments

@quigleyj97
Copy link
Contributor

On hidpi displays, the app clips a few UI elements and fails to properly lay out others. I've pasted screenshots below detailing some of the problems I found.

Normally Qt should handle this but it looks like it isn't (or maybe I have a few wires crossed about the extent Qt is involved- I ran into similar issues on other Qt apps)

This is on a Surface Pro 4, which has a ~12" ~4k display at 200% UI scaling.

There is a workaround for this, but it's rather onerous for an end user: you need to override the scaling by right-clicking on the app in the taskbar, then right clicking the executable in the menu that pops up, "Properties" > "Compatibility" > "Change high DPI settings" > "Override application scaling" and set it to "System" or "System (enhanced)".

Clipping of UI elements:
Clipping of UI elements

Alerts dialog is too small, editors are not visible until you expand them:
image
image

Propellant editor is too cramped to use by default:
image

(Separately I can't get to the resize grip on this window- not sure if this is related).

@reilleya
Copy link
Owner

Ouch, that's pretty bad! It looks like Qt is allowing the text to be resized by the system scale factor but not giving it room in the UI. I didn't use any fixed coordinates for UI elements or anything, so I don't think that is the problem. The Qt docs seem to have some solutions here: https://doc.qt.io/qt-5/highdpi.html. I can't really test this myself as I don't have anything particularly high DPI, so would you like to look into the solutions on the doc page?

@reilleya reilleya added bug Something isn't working ui For issues related to the UI labels Jul 14, 2019
@reilleya reilleya added this to the 0.4.0 milestone Jul 14, 2019
@quigleyj97
Copy link
Contributor Author

Looking into this now. Setting QT_AUTO_SCREEN_SCALE_FACTOR=1 fixes most resolution issues, the only major issues so far have been window size (at the minimum size it's almost as big as my screen) and the legend position on the simulation graph.

image

quigleyj97 added a commit to quigleyj97/openMotor that referenced this issue Jul 20, 2019
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldly large.

Fixes reilleya#101
@reilleya reilleya added the staging Code for this issue is on staging label Jul 26, 2019
@reilleya reilleya reopened this Jul 26, 2019
AstroChuck pushed a commit to AstroChuck/openMotor that referenced this issue Jul 29, 2019
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldly large.

Fixes reilleya#101
@reilleya reilleya closed this as completed Aug 3, 2019
AstroChuck pushed a commit to AstroChuck/openMotor that referenced this issue Aug 4, 2019
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldly large.

Fixes reilleya#101
AstroChuck pushed a commit to AstroChuck/openMotor that referenced this issue Sep 11, 2019
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldly large.

Fixes reilleya#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working staging Code for this issue is on staging ui For issues related to the UI
Projects
None yet
Development

No branches or pull requests

2 participants