Change: Set EnableHighDpiScaling flag for high DPI support #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldly large. Fixes reilleya#101
|
Looks good! Could you make this a PR into staging instead of master? (Same thing with the docs) |
|
Whoops! Done for both. |
|
Unfortunately, this doesn't seem to work on gnome. |
|
Ouch... Do you think we should hide this behind a platform check? I think there's some deeper issues to resolve in the layout scaling but I'd rather not play cross-platform whack-a-mole... |
|
Yup, Though all the platform-dependent switch statements are supposed to be in Qt itself I think this might be the best way to proceed until someday if/when someone decides to completely rewrite the UI. |
This is every bit the hacky workaround that it looks like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldy because it's minimum size is still quite large.
I took a stab at a few other avenues, since it should "just work", but it seems to be pretty deep into the weeds with how Qt layouts work and I don't have enough experience with Qt to resolve them right now.
I don't have access to an OSX device, so I haven't been able to test this on other platforms.
Fixes #101