Merge pull request #135 from reindexio/validate-presense-of-User-type

Make migrate ensure that User type is present
reindexio · Oct 12, 2015 · fb720c9 · fb720c9
2 parents cf3be0a + 7c1bc89
commit fb720c9
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/db/migrations/__tests__/validateSchema.js b/db/migrations/__tests__/validateSchema.js
@@ -259,6 +259,16 @@ describe('validateSchema', () => {
     ]);
   });
 
+  it('reports missing required types', () => {
+    const types = [
+      type('Foo'),
+    ];
+    const errors = validateSchema({ types }, interfaces, ['User']);
+    assert.deepEqual(errors, [
+      'Expected User type to be present.',
+    ]);
+  });
+
   it('reports duplicated plural names', () => {
     const types = [
       type('Typo'),

diff --git a/db/migrations/validateSchema.js b/db/migrations/validateSchema.js
@@ -11,7 +11,11 @@ import { getName, byName } from './utilities';
 const InterfaceDefaultFields = getInterfaceDefaultFields();
 const TypeDefaultFields = getTypeDefaultFields();
 
-export default function validateSchema({ types }, interfaces) {
+export default function validateSchema(
+  { types },
+  interfaces,
+  requiredTypes = []
+) {
   const errors = [];
   function invariant(...args) {
     try {
@@ -54,6 +58,19 @@ export default function validateSchema({ types }, interfaces) {
     return errors;
   }
 
+  const typeNames = types.map(getName);
+  for (const requiredType of requiredTypes) {
+    invariant(
+      typeNames.includes(requiredType),
+      'Expected %s type to be present.',
+      requiredType
+    );
+  }
+
+  if (errors.length > 0) {
+    return errors;
+  }
+
   const typesByName = byName(types);
   types.forEach((type) =>
     validateType(type, typesByName, interfaces, invariant)

diff --git a/graphQL/mutations/createMigrate.js b/graphQL/mutations/createMigrate.js
@@ -84,7 +84,9 @@ export default function createMigrate(typeSets, interfaces) {
         context,
       );
 
-      const errors = validateSchema({ types: input.types }, interfaces);
+      const errors = validateSchema({ types: input.types }, interfaces, [
+        'User',
+      ]);
 
       setImmediate(() => {
         trackEvent(context.rootValue.credentials, 'pushed-schema', {