Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.cloud.datastore add_filter warnings #56

Merged
merged 2 commits into from Mar 14, 2024
Merged

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Mar 13, 2024

refs googleapis/python-datastore#504

To get rid of:

UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.

Untested locally, so do not merge unless CI passes and CI uses one of these filters.

@dhimmel
Copy link
Member Author

dhimmel commented Mar 13, 2024

3 CI tests failed due to

FAILED articat/tests/utils_test.py::test_download__empty - FileExistsError: [Errno 17] File exists: '/tmp/tmpsmeymxih'
FAILED articat/tests/utils_test.py::test_download__weird_valid_pattern - ValueError: Invalid pattern: '**' can only be an entire path component
FAILED articat/tests/utils_test.py::test_download__embedded_dir - FileExistsError: [Errno 17] File exists: '/tmp/tmp06uvrlun'

But this occurs on main as well.

@danielhfrank
Copy link
Contributor

I'm running down the test failures that you mentioned, and believe it may be related to a newer version of fsspec being released since we last updated the repo. I'll continue working on that, and make sure that tests pass on both 3.10 and 3.11

@dhimmel
Copy link
Member Author

dhimmel commented Mar 13, 2024

Sounds good. I don't think there is any need for articat to support dependency versions lower than what we use internally in facets in case that simplifies the code updates.

refs googleapis/python-datastore#504

To get rid of:
UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.
@dhimmel dhimmel merged commit af327df into main Mar 14, 2024
1 check passed
@dhimmel dhimmel deleted the dsh-field-filter-warnings branch March 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants