Skip to content

Commit

Permalink
fix(ui,utils): Browsertime - support v5
Browse files Browse the repository at this point in the history
  • Loading branch information
vio committed Aug 19, 2019
1 parent afdb19c commit 48bb48c
Show file tree
Hide file tree
Showing 2 changed files with 86 additions and 84 deletions.
168 changes: 85 additions & 83 deletions packages/ui/__mocks__/browsertime.json
@@ -1,89 +1,91 @@
{
[
{
"info": {
"browsertime": {
"version": "2.1.4"
},
"connectivity": {
"engine": "external",
"profile": "native"
},
"timestamp": "2018-02-28T18:43:38+00:00",
"url": "https://mobile.twitter.com/sitespeedio"
"browsertime": {
"version": "5.7.3"
},
"connectivity": {
"engine": "external",
"profile": "native"
},
"timestamp": "2018-02-28T18:43:38+00:00",
"url": "https://mobile.twitter.com/sitespeedio"
},
"statistics": {
"timings": {
"firstPaint": {
"median": 317
},
"fullyLoaded": {
"median": 2695
},
"pageTimings": {
"backEndTime": {
"median": 274
},
"domContentLoadedTime": {
"median": 811
},
"domInteractiveTime": {
"median": 811
},
"domainLookupTime": {
"median": 3
},
"frontEndTime": {
"median": 413
},
"pageDownloadTime": {
"median": 98
},
"pageLoadTime": {
"median": 819
},
"redirectionTime": {
"median": 2
},
"serverConnectionTime": {
"median": 108
},
"serverResponseTime": {
"median": 257
}
},
"paintTiming": {
"first-contentful-paint": {
"median": 317
},
"first-paint": {
"median": 317
}
},
"rumSpeedIndex": {
"median": 471
}
"timings": {
"firstPaint": {
"median": 317
},
"fullyLoaded": {
"median": 2695
},
"pageTimings": {
"backEndTime": {
"median": 274
},
"domContentLoadedTime": {
"median": 811
},
"domInteractiveTime": {
"median": 811
},
"domainLookupTime": {
"median": 3
},
"frontEndTime": {
"median": 413
},
"pageDownloadTime": {
"median": 98
},
"pageLoadTime": {
"median": 819
},
"redirectionTime": {
"median": 2
},
"serverConnectionTime": {
"median": 108
},
"serverResponseTime": {
"median": 257
}
},
"paintTiming": {
"first-contentful-paint": {
"median": 317
},
"first-paint": {
"median": 317
}
},
"rumSpeedIndex": {
"median": 471
}
},
"visualMetrics": {
"FirstVisualChange": {
"median": 1200
},
"LastVisualChange": {
"median": 2933
},
"PerceptualSpeedIndex": {
"median": 1433
},
"SpeedIndex": {
"median": 1388
},
"VisualComplete85": {
"median": 1800
},
"VisualComplete95": {
"median": 1900
},
"visualMetrics": {
"FirstVisualChange": {
"median": 1200
},
"LastVisualChange": {
"median": 2933
},
"PerceptualSpeedIndex": {
"median": 1433
},
"SpeedIndex": {
"median": 1388
},
"VisualComplete85": {
"median": 1800
},
"VisualComplete95": {
"median": 1900
},
"VisualComplete99": {
"median": 2800
}
"VisualComplete99": {
"median": 2800
}
}
}
}
}
]
2 changes: 1 addition & 1 deletion packages/utils/src/browsertime/get-browsertime-metrics.js
Expand Up @@ -33,7 +33,7 @@ export const getBrowsertimeMetrics = (browsertime) => {
.reduce((agg, [metricKey, metricPath]) => ({
...agg,
[metricKey]: {
value: get(browsertime, metricPath, 0),
value: get(browsertime, `0.${metricPath}`, 0),
},
}), {});
};

0 comments on commit 48bb48c

Please sign in to comment.