Add noThrow option to NetworkLayer advanced options #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks a lot! 馃憤 |
|
@nodkz Don't you need to create an npm release (if you haven't already - maybe it's still processing)? https://www.npmjs.com/package/react-relay-network-layer (last published 3 months ago) |
|
And my pleasure, it's a great library 馃憤 |
|
Sorry, it should be done automatically via semantic-release. But by travis logs happened some error when publishing the package. I get to work and fix it in an hour or two. |
|
Successfully published react-relay-network-layer@2.2.0 Sorry for the delay. Usually, CI publishes automatically a new version after merging. I repaired it, so for next PRs it should work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that no errors are thrown if
noThrow = true. It brings the same noThrow functionality as: https://github.com/relay-tools/react-relay-network-modern#advanced-options-2nd-argument-after-middlewaresIt's working for me 馃憤I purposely threw errors from my backend and it doesn't throw the error.
Useful links: