-
Notifications
You must be signed in to change notification settings - Fork 69
Trying to use multiple artefact directories with 9.0.0 #150
Comments
@ds300 We should give this a try in our codebase (Emission). |
Don't you think that #149 will fix this incompatibility? |
@renanmav I’m unsure what part of that you think may fix this, can you elaborate? Theoretically this should already be working afaik. |
Now, we splitted into import { FragmentRefs } from "relay-runtime";
export type TodoApp_viewer = {
readonly id: string;
readonly totalCount: number | null;
readonly " $fragmentRefs": FragmentRefs<"TodoListFooter_viewer" | "TodoList_viewer">;
readonly " $refType": "TodoApp_viewer";
};
export type TodoApp_viewer$data = TodoApp_viewer;
export type TodoApp_viewer$key = {
readonly " $data"?: TodoApp_viewer$data;
readonly " $fragmentRefs": FragmentRefs<"TodoApp_viewer">;
};
|
@sgwilym I saw this temporarily when upgrading our app at Artsy. It seemed like there was a duplicate definition of In hindsight it might just have been a TS caching issue. So try what I did above, and if that doesn't work we can debug further. |
@ds300 Another version of @types/relay-runtime had snuck into our yarn.lock and had to be removed manually. After that, everything checks out. Thanks! |
Great to know! |
I was taking a a look at #139 and this interested me:
This is very fortunate timing as I'm starting a project in a monorepo where having many artifact directories would be very useful. So I decided to give it a spin:
relay-compiler-language-typescript@v9.0.0
@types/relay-runtime@6.0.7
--artifactDirectory
option from my relay compiler commandAnd then I got stuck. Where relay props are passed down into a child component, Typescript raises errors like the following:
I am admittedly not a Typescript expert so it's hard for me to untangle what the issue is here. Any ideas what could be going wrong here?
The text was updated successfully, but these errors were encountered: