Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

New release with latest plugin-version #41

Closed
arieldf opened this issue Mar 23, 2018 · 10 comments
Closed

New release with latest plugin-version #41

arieldf opened this issue Mar 23, 2018 · 10 comments

Comments

@arieldf
Copy link

arieldf commented Mar 23, 2018

@alloy Thanks a lot for the great work here. Will there be a new release of this library with the plugin-updates from today?

Best regards,
Ariel

@alloy
Copy link
Member

alloy commented Mar 23, 2018

Oh great question! Actually the way I’ve been using it, due to various transitive dependencies that really should all be using the same versions, is by using yarn’s resolutions feature, which is also how it’s being used in the example app’s setup.

Hope that helps!

@arieldf
Copy link
Author

arieldf commented Mar 23, 2018

@alloy Great! Thanks - I did not understand the resolutions correctly. Thanks again for the great efforts here

@arieldf arieldf closed this as completed Mar 23, 2018
@alloy
Copy link
Member

alloy commented Mar 23, 2018

Thanks for testing and please give us any feedback on the PR whilst things have not been merged yet!

@arieldf
Copy link
Author

arieldf commented Mar 25, 2018

@alloy So far things are working nice! I do get the errors below when starting the app, but things seem to work as expected.

ERROR in project/packages/modules/example/ts/app.tsx(74,25):
TS2322: Type '{ viewer: any; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: any; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: any; }'.
ERROR in project/packages/modules/example/ts/components/TodoApp.tsx(56,21):
TS2322: Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: TodoApp_viewer; }'.
ERROR in project/packages/modules/example/ts/components/TodoApp.tsx(57,40):
TS2322: Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: TodoApp_viewer; }'.
ERROR in project/packages/modules/example/ts/components/TodoList.tsx(49,9):
TS2322: Type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...'.
Version: typescript 2.6.2

@alloy
Copy link
Member

alloy commented Mar 25, 2018

Are you using the latest versions of the @types/react-relay and @types/relay-runtime packages?

@alloy
Copy link
Member

alloy commented Mar 25, 2018

Or can you otherwise include a failing code snippet?

@arieldf
Copy link
Author

arieldf commented Mar 27, 2018

@alloy, so this turned out to be a clash with typings. I removed the relay-runtime and react-relay types and it works (I am using latests React).

@alloy
Copy link
Member

alloy commented Mar 27, 2018

Did you remove them completely? Or did you remove the clashing ones?

@arieldf
Copy link
Author

arieldf commented Mar 28, 2018

I removed the types for relay-runtime and react-relay and it is working nicely. Would be nice to have the types, but in my case I am fine without.

@alloy
Copy link
Member

alloy commented Mar 29, 2018

The typings should be working, though, it does for us at least and otherwise it’s a bug. Could you try to create a minimal example project that exhibits the problem?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants