Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fixing TypeScript 4.5 type generation #519

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Fixing TypeScript 4.5 type generation #519

merged 3 commits into from
Nov 23, 2021

Conversation

fxOne
Copy link
Contributor

@fxOne fxOne commented Nov 23, 2021

This is a breaking change as it wont work with older TypeScript versions!

closes #513

@fxOne fxOne added the Version: Major Increment the major version when merged label Nov 23, 2021
@wongmjane
Copy link

Thanks a lot!

Specifically, the breaking change is microsoft/TypeScript#45998 (allowing type-only import specifiers) which changed createImportSpecifier’s call signature,

from:

createImportSpecifier(
  propertyName: Identifier | undefined,
  name: Identifier
): ImportSpecifier;

to:

createImportSpecifier(
  isTypeOnly: boolean,
  propertyName: Identifier | undefined,
  name: Identifier
): ImportSpecifier;

@saihaj saihaj merged commit bbf8e73 into relay-tools:master Nov 23, 2021
@github-actions
Copy link

🚀 PR was released in v15.0.0 🚀

@szakhlypa szakhlypa mentioned this pull request Feb 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sibelius sibelius sibelius approved these changes

@saihaj saihaj saihaj approved these changes

Assignees
No one assigned
Labels
released Version: Major Increment the major version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript 4.5 type generation is broken
4 participants
@fxOne @wongmjane @sibelius @saihaj