Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support? #91

Closed
nirvdrum opened this issue Apr 22, 2020 · 7 comments
Closed

TypeScript support? #91

nirvdrum opened this issue Apr 22, 2020 · 7 comments

Comments

@nirvdrum
Copy link

I'm working on an overdue migration from TSLint to ESLint due to the former's deprecation in favor of the latter. I had been using a plugin called tslint-plugin-relay, which ported rules from this project over to TypeScript. Is there any interest in supporting TypeScript rules to parallel the Flow rules? If so, I'd be happy to work on upstreaming work from tslint-plugin-relay. If not, I can work on separate plugin instead.

@sibelius
Copy link

what does not work with typescript?

If you use @typescript-eslint/parser it should work

@nirvdrum
Copy link
Author

The project at large works with TypeScript, but plugin:relay/recommended enables relay/generated-flow-types, which doesn't work in any non-Flow project. That needs to be explicitly disabled in the ESLint rules configuration. I was inquiring about a parallel rule set to relay/generated-flow-types that would provide a similar type of linting with TypeScript in mind.

@matthieu-foucault
Copy link

I do have an issue where relay/unused-fields does not output information about the line number, making the warning easy to miss when only looking at the IDE

@natelindev
Copy link
Contributor

I'll try with PR #115, no promises

@reckter
Copy link
Contributor

reckter commented Nov 20, 2021

I managed to get it working in #128, thanks to @llldar work in #115 :D

@gajus
Copy link

gajus commented Jun 7, 2022

What dose generated-flow-types do?

@alloy
Copy link
Collaborator

alloy commented Sep 9, 2023

#128 has been merged

@alloy alloy closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants