-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "generated-typescript-types" rule #115
Conversation
natelindev
commented
Apr 12, 2021
- use typeParameters instead of typeArguments.
- updated foundImport logic since typescript does not have importKind.
- added ts-recommended and ts-strict
* use typeParameters instead of typeArguments. * updated foundImport logic since typescript does not have importKind. * added ts-recommended and ts-strict
Hi @llldar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have tests for this?
It's currently very much incomplete, I'll let you know when I consider it's ready. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hey any progress on this? :) Just stumbled upon this issue, and would love this lint rule! |
sry I didn't have much time on this, anyone is welcomed to continue on my progress |
#128 got merged, which has these changes and more |