Adding celery scaffold to the project. #36
Conversation
fuzzball81
force-pushed
the
celery-integration
branch
from
51c1ca1
to
bf1c5f3
Compare
|
The changes to tox and the GitHub action are due to an issue in import lib-metadata in python 3.7 see python/importlib_metadata#411 for more details. If we no longer need 3.7 support we could just remove that from tox and the action and everything should just work. |
fuzzball81
force-pushed
the
celery-integration
branch
from
bf1c5f3
to
d7e752a
Compare
I would advocate removing 3.7 support so we don't have to make changes to work around it. That version is EOL, and I already removed it elsewhere. Happy to make a patch for that if it would help. |
Go for it, I am happy to rebase my patch on that. We may want another patch to add 3.12 since that is the default in Fedora now. |
fuzzball81
force-pushed
the
celery-integration
branch
5 times, most recently
from
4f13411
to
9482e98
Compare
fuzzball81
force-pushed
the
celery-integration
branch
2 times, most recently
from
3ea4232
to
d947d91
Compare
| # Add the celery app as an extension to the flask app so it can be easily | ||
| # accessed if a flask application factory pattern is used. | ||
| # see https://flask.palletsprojects.com/en/2.3.x/patterns/celery/ for details. | ||
| self.flask_app.extensions["celery"] = self.celery_app |
There was a problem hiding this comment.
This is a good improvement if it helps when the factory pattern is used, as I know a number of our applications do this currently.
There was a problem hiding this comment.
This provides a lot of flexibility, if you want to access the celery app from the flask app you can, or you can use the class attribute. This doesn't force a single implementation pattern, which I like.
There was a problem hiding this comment.
(praise) Really enjoying the README updates including link to relevant docs and installation/usage examples, really helpful!
It's really cool to see how nicely this works out. I'm approving although I'd like to see the rewording improvement suggested by Jay implemented if possible, as it also tripped me up on first read. Thanks for the patch!
| @@ -28,6 +28,9 @@ install_requires = | |||
| toolchest | |||
|
|
|||
| [options.extras_require] | |||
| celery = | |||
| celery | |||
There was a problem hiding this comment.
(praise) I really like how self-contained the additions are, here and in the Pipfile, install instructions, etc. It works really neatly.
Adding celery_scaffold for use with flask based projects. It provides a way to configure celery for use, using the flask configuration files. It also provides a celery_app and a flask_app that can be used in your project. A base_scaffold was pulled out due to the celery worker assuming any 'app' attribute is of type Celery. The original app_scaffold is available to provide backward compatibility. It leverages the new base_scaffold and sets the 'app' attribute to flask_app to ensure existing use cases are handled. Signed-off-by: Jason Joyce <jjoyce@redhat.com>
fuzzball81
force-pushed
the
celery-integration
branch
from
d947d91
to
ea37426
Compare
Adding celery_scaffold for use with flask based projects. It provides a way to configure celery for use, using the flask configuration files. It also provides a celery_app and a flask_app that can be used in your project.
A base_scaffold was pulled out due to the celery worker assuming any 'app' attribute is of type Celery. The original app_scaffold is available to provide backward compatibility. It leverages the new base_scaffold and sets the 'app' attribute to flask_app to ensure existing use cases are handled.