Split into Action, App, CLI, Core and Switch to TypeScript #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
commented
Aug 3, 2022
| ENTRYPOINT [ "/app/node_modules/.bin/probot" ] | ||
| CMD [ "receive", "/app/index.js" ] | ||
|
|
||
| FROM node:16.16.0-alpine@sha256:9a2db0008b592cfde1b98aa8972a8051ccb80bb51dde8b06c3a2e3762794e89c as run |
There was a problem hiding this comment.
The intent was to copy over only a single nodejs produced by @vercel/ncc
jetersen
commented
Aug 3, 2022
packages/app/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| dist/ | |||
There was a problem hiding this comment.
move packages/app/dist/ to .gitignore
jetersen
commented
Aug 3, 2022
.github/release-drafter.yml
Outdated
| @@ -1,5 +1,6 @@ | |||
| name-template: 'v$RESOLVED_VERSION' | |||
| tag-template: 'v$RESOLVED_VERSION' | |||
| # yamlLanguageServer: $schema=../schema.json | |||
There was a problem hiding this comment.
This is useful for testing the schema locally
this alllows for easier transformation of string to regex!
use prettier to format schema.json
|
argh I need to move this to release-drafter repo so workflows get updated 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly an entire rewrite of the code base into typescript with multiple packages.
I will rewrite history a lot in the pull request and it is definitely not in a working state at the moment.
pnpmpackage manager dependabot/dependabot-core#1736closes #1173
fixes #549
fixes #667
fixes #148
fixes #1146