New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supports for custom replacer #185
Add supports for custom replacer #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @halkeye 🙇♂️. I left some minor feedback but overall it looks good to me 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I have a few concerns
Okay, thanks for the review, I think i got everything brought up handled. |
travis needs a retry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @halkeye — looks great! 👌🏼 First PR too! 🎉
I have some readme edits, and then we're good to go.
Co-Authored-By: halkeye <github@gavinmogan.com>
Co-Authored-By: halkeye <github@gavinmogan.com>
Co-Authored-By: halkeye <github@gavinmogan.com>
Co-Authored-By: halkeye <github@gavinmogan.com>
Thanks for all the comments and suggestions @toolmantim I think i addressed them all, as well as fought with the master merge, so I think its ready to go again. |
Thanks for the updates, you’re awesome! 🎉🎉🎉🎉 |
:D SO EXCITED How often do you release it to the actual github app? when can i start using it? |
I'm leaning towards adding the sorting option first because we're changing the default sorting direction which might be confusing to users. But I don't have a strong opinion about it so I'll leave the decision to you @toolmantim, I'll probably have some time tomorrow to start implementing the sorting option :) |
try { | ||
if (replacer.regex) { | ||
return { | ||
search: regexParser(replacer.regex), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheeky beep 😆 I spent an hour thinking my schema addition was borked when in reality you modified the schema. 😡 At myself for not reading the code more closely before deleting it 😆
super related to #168
Allows custom regexes to be applied.