Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ‘regex’ key from the ‘search’ option #194

Merged
merged 1 commit into from Apr 29, 2019
Merged

Remove ‘regex’ key from the ‘search’ option #194

merged 1 commit into from Apr 29, 2019

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Apr 28, 2019

In #185 we added a new replacers option, that had two separate sub-keys: regex and search. This simplifies the config down to a single search key that can handle both plain string values, and strings that look like a regular expression.

The regex key can no longer be used.

@toolmantim toolmantim changed the title use search only Remove ‘regex’ key from the ‘search’ option Apr 28, 2019
@toolmantim
Copy link
Collaborator

toolmantim commented Apr 28, 2019

Thanks for the PR @Casz! Why don’t we just change the code in here too? I’d prefer PRs that only change a thing at a time, so it’d be nice to do each one on their own, with a well structured PR title and description for future people wanting to understand the changes.

And then after, we can rebase #193?

@jetersen
Copy link
Member Author

There @toolmantim fixed the code as well :)

@toolmantim
Copy link
Collaborator

Thanks @Casz! I just updated the PR description too 🙌🏼

@toolmantim toolmantim merged commit 8e59b96 into release-drafter:master Apr 29, 2019
@jetersen jetersen deleted the patch-1 branch April 29, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants