Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Pagure description from Markdown to Jira format #113

Closed
wants to merge 1 commit into from

Conversation

hluk
Copy link
Member

@hluk hluk commented Nov 11, 2020

Fixes also following exception:

TypeError: not all arguments converted during string formatting

@hluk
Copy link
Member Author

hluk commented Nov 11, 2020

It would be also safer to use {panel:title=Upstream Description}...{panel} instead of {quote}...{quote} because quotes in the description or comment would break the formatting.

@ralphbean
Copy link
Member

Can you add the following to the travis file?

before_install:
- sudo apt-get install -qq pandoc

@hluk hluk force-pushed the pagure-markdown branch 2 times, most recently from 2b78c8e to 640efcf Compare November 19, 2020 15:35
@hluk
Copy link
Member Author

hluk commented Nov 20, 2020

Can you add the following to the travis file?

before_install:
- sudo apt-get install -qq pandoc

Unfortunately, pandoc in the latest ubuntu (20.04) available on Travis CI is too old (version 2.5) and doesn't contain jira output format.

Using Github Actions would work, but it's bigger change. This would also speed up the builds I think - Travis CI is now very slow.

Any other ideas how to use newer pandoc for tests?

@hluk
Copy link
Member Author

hluk commented Nov 20, 2020

I'm trying to get the GitHub Actions working for this: #114

@ralphbean
Copy link
Member

Weird - any luck with github actions?

@hluk
Copy link
Member Author

hluk commented Dec 3, 2020

Unfortunately, I haven't got much time to look into this. Perhaps the patch needs to be merged to master to start working.

@sidpremkumar Any idea if something is overriding the CI in this github project? I'm not sure where "Sync2Jira Build" test is coming from.

Replacing the Travis CI is needed because it's going away at the end of the year:

... we are announcing that travis-ci.org will be officially closed down completely on December 31st, 2020 ...

@sidpremkumar
Copy link
Collaborator

Oh wow, I didn't know Travis was closing.

Sync2Jira build is coming from settings -> Integrations. It's set up as a webhook that pushes to quay. Then there is an OpenShift instance running that listens to that quay webhook, performs some integration tests, and then pushes back up.

I'm not sure if I have access to it anymore, but if I do feel free to ping me and we can get it sorted.

Let me know if there is anything else I can help with. Would love to contribute any way I can.

@sidpremkumar
Copy link
Collaborator

I believe the reason the sync2jira build is faling is because the Jira tickets are not synced correctly. There should be a config file in OpenShift that maps the upstream issues to downstream JIRA tickets. But every so often the JIRA tickets get updated and the numbering gets thrown out of wack. See this.

If its too much trouble and not providing much utility (which i feel it might), might be best to just remove sync2jira build entierly. I just put it there becuase when I was working on Sync2Jira I found is useful to have some integration tests before merging to master.

@hluk
Copy link
Member Author

hluk commented Jan 8, 2021

Updated. Now the tests pass.

@sidpremkumar Looks like currently the integration tests (failing Sync2Jira Build) only compare values in existing Jira issues. This doesn't seem to be useful but maybe I'm missing something.

@sidpremkumar
Copy link
Collaborator

sidpremkumar commented Jan 17, 2021

@hluk yes, I would probably remove them or spend some time and fix them. I worked on them when I had some free time during my internship. More of a test project vs. something super useful. If you choose to fix them I would be more than glad to help work on that.

@hluk
Copy link
Member Author

hluk commented May 24, 2021

Is this OK to merge?

@hluk hluk closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants