Fix missing files from kickstart indexes [RHELDST-22387] #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHELDST-22148 introduced the concept of a partial autoindex, which is triggered as soon as entry points are added onto a publish without waiting until commit. This introduced a problem for kickstart repos. The problem is that a kickstart repo is simultaneously a valid yum repo, containing both yum and kickstart entrypoints. There is no guarantee in which order the client will add these onto a publish. If the client added yum repodata first, partial autoindex could be triggered and successfully parse the repo as a yum repo (only). If the client then later added kickstart repodata, the autoindex would not be regenerated to include kickstart files, because the index is treated as immutable and assumed valid if it already exists on the publish. This commit fixes the problem by effectively disabling partial autoindex for kickstart repos, allowing them to instead generate indexes at commit time as it worked originally. This can be considered more of a workaround than a proper fix. A better fix might be done later to make autoindex_partial work correctly for kickstart repos rather than disabling it.
negillett
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHELDST-22148 introduced the concept of a partial autoindex, which is triggered as soon as entry points are added onto a publish without waiting until commit.
This introduced a problem for kickstart repos. The problem is that a kickstart repo is simultaneously a valid yum repo, containing both yum and kickstart entrypoints. There is no guarantee in which order the client will add these onto a publish.
If the client added yum repodata first, partial autoindex could be triggered and successfully parse the repo as a yum repo (only). If the client then later added kickstart repodata, the autoindex would not be regenerated to include kickstart files, because the index is treated as immutable and assumed valid if it already exists on the publish.
This commit fixes the problem by effectively disabling partial autoindex for kickstart repos, allowing them to instead generate indexes at commit time as it worked originally.
This can be considered more of a workaround than a proper fix. A better fix might be done later to make autoindex_partial work correctly for kickstart repos rather than disabling it.