Return 404 responses for 'absent' items [RHELDST-9952] #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dichn
requested review from
rohanpm,
negillett and
crungehottman
as code owners
negillett
previously approved these changes
Feb 14, 2022
rohanpm
reviewed
Feb 14, 2022
| if object_key == "absent": | ||
| self.logger.info("Item absent for '%s'", uri) | ||
| return {"status": "404", "statusDescription": "Not Found"} | ||
| else: |
There was a problem hiding this comment.
Can the "else" please be dropped to reduce unnecessary nesting?
It has no effect since the "if" case always returns. It's also arbitrary that you put only one line of code in it. Every line of code between here and "return request" should execute only in the "item found" case, what's special about this one line of code which makes sense for it to be in "else" and not any of the others?
In order to support the explicit deletion/hiding of content on exodus-cdn, it should make exodus-lambda return 404 responses for URIs which have been marked as absent.
rohanpm
approved these changes
Feb 15, 2022
negillett
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the explicit deletion/hiding of content on
exodus-cdn, it should make exodus-lambda return 404 responses for URIs
which have been marked as absent.