Add topic to the message body #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems silly, but it is here to appease a codepath for legacy fedmsg-based consumers, notably: datanommer. This codepath is to blame: https://github.com/fedora-infra/fedmsg/blob/develop/fedmsg/consumers/__init__.py#L254-L259 There, if there is no topic in the body, then the fedmsg base class that prepares the message before it is passed onto the application's `consume` method tries to be helpful by "massaging" what is assumed to be a stomp message from a non-fedmsg based system into a fedmsg-friendly message by wrapping a `msg: {` envelope around it. This causes problems reported in EXDSP-1169. Ideally, that fedmsg codepath should be updated to do this more carefully. Adding a topic to the greenwave message body like in this commit should be harmless to other consumers and should succeed in working around the legacy fedmsg framework.
ralphbean
force-pushed
the
fedmsg-backwards-compat
branch
from
30ed462
to
79db2b5
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems silly, but it is here to appease a codepath for
legacy fedmsg-based consumers, notably: datanommer.
This codepath is to blame: https://github.com/fedora-infra/fedmsg/blob/develop/fedmsg/consumers/__init__.py#L254-L259
There, if there is no topic in the body, then the fedmsg base class
that prepares the message before it is passed onto the application's
consumemethod tries to be helpful by "massaging" what is assumedto be a stomp message from a non-fedmsg based system into
a fedmsg-friendly message by wrapping a
msg: {envelope around it.This causes problems reported in EXDSP-1169.
Ideally, that fedmsg codepath should be updated to do this more
carefully. Adding a topic to the greenwave message body like in
this commit should be harmless to other consumers and should succeed
in working around the legacy fedmsg framework.