Check whether default_profile has been set #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a probaly forgotten check of default_profile emptiness. As stated in comment in kobo/cli.py, line 288 (PR release-engineering#148): this block should only be evaluated if default_profile has been set at instantiation _load_profile() should be executed only if default_profile is set/nonempty, otherwise there is a danger of passing empty strings and getting paths like /etc/.conf (see issue release-engineering#151).
Pull Request Test Coverage Report for Build 302
💛 - Coveralls |
rohanpm
approved these changes
Jan 21, 2021
|
Thank both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a probably forgotten check of
default_profileemptiness. As stated here,_load_profile()should be executed only ifdefault_profileis set/nonempty, otherwise there is a danger of passing empty strings and getting paths like/etc/.conf(see issue #151).