Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_query_set is deprecated #155

Merged

Conversation

i386x
Copy link
Contributor

@i386x i386x commented Mar 5, 2021

Since Django >= 1.6, get_query_set is being deprecated and replaced by get_queryset, see
https://docs.djangoproject.com/en/dev/releases/1.6/#get-query-set-and-similar-methods-renamed-to-get-queryset

@coveralls
Copy link

Pull Request Test Coverage Report for Build 306

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 50.317%

Totals Coverage Status
Change from base Build 304: 0.02%
Covered Lines: 3096
Relevant Lines: 6153

💛 - Coveralls

@lzaoral
Copy link
Contributor

lzaoral commented Mar 9, 2023

@i386x It looks like this PR got overlooked. Can you rebase it please if it is still relevant?

- since Django >= 1.6, `get_query_set` is being deprecated and
  replaced by `get_queryset`, see
  https://docs.djangoproject.com/en/dev/releases/1.6/#get-query-set-and-similar-methods-renamed-to-get-queryset
@i386x i386x force-pushed the fix-django-depracated-methods branch from 08abd26 to f0de161 Compare March 15, 2023 11:16
@rohanpm rohanpm merged commit 8ac7b5a into release-engineering:master Mar 19, 2023
siteshwar pushed a commit to openscanhub/openscanhub that referenced this pull request May 22, 2023
- `get_query_set` is deprecated, `get_queryset` should be used
  instead
- more info in release-engineering/kobo#155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants