Only log this statement when replacement will really happen.

Otherwise, our logs are full of lines indicating that something is being replaced, with little indication of what is really happening.
release-engineering · Sep 2, 2019 · ec48e18 · ec48e18
1 parent 1ad6d1b
commit ec48e18
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/omps/quay.py b/omps/quay.py
@@ -259,8 +259,9 @@ def replace_registries(self, text):
         for conf in self._replace_registry_conf:
             old = conf['old']
             new = conf['new']
-            self.logger.info("Replacing registry '%s' with '%s'", old, new)
-            text = text.replace(old, new)
+            if old in text:
+                self.logger.info("Replacing registry '%s' with '%s'", old, new)
+                text = text.replace(old, new)
 
         return text