Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Integration: test flattening of nested manifests #60

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Integration: test flattening of nested manifests #60

merged 1 commit into from
Apr 8, 2019

Conversation

csomh
Copy link
Contributor

@csomh csomh commented Apr 8, 2019

Add tests to check that flattening of nested manifests works as
expected.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

@csomh csomh requested a review from MartinBasti April 8, 2019 10:32
repo=test_env['test_package'], archive=archive)

assert response.status_code == requests.codes.server_error
# TODO(csomh): Check the message in response.json() once the fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is, but it's not released yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe comment that it is related to release of operator-framework/operator-courier#92 could be handy

Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after TODO comment is updated

Add tests to check that flattening of nested manifests works as
expected.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
@csomh csomh merged commit dbfda64 into release-engineering:master Apr 8, 2019
@csomh csomh deleted the test-flatten-manifests branch April 15, 2019 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants