Skip to content

Commit

Permalink
Use pubtools namespace to resolve init file conflict [RHELDST-17607]
Browse files Browse the repository at this point in the history
Currently, there's an issue with packaging where most of the pubtool-<lib> projects
contains __init__.py and other stuff which is supposed to belong only to pubtools.
Python namespaces are a convenient way to work around this issue.
  • Loading branch information
amcmahon-rh committed May 30, 2024
1 parent f434506 commit ec581e7
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 6 deletions.
1 change: 0 additions & 1 deletion pubtools/exodus/__init__.py

This file was deleted.

5 changes: 3 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from setuptools import find_packages, setup
from setuptools import find_namespace_packages, setup


def get_description():
Expand All @@ -22,7 +22,8 @@ def get_requirements():
setup(
name="pubtools-exodus",
version="1.5.1",
packages=find_packages(exclude=["tests"]),
packages=find_namespace_packages(where="src"),
package_dir={"": "src"},
include_package_data=True,
url="https://github.com/release-engineering/pubtools-exodus",
license="GNU General Public License",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ allowlist_externals=sh

[testenv:static]
commands=
sh -c 'pylint pubtools; test $(( $? & (1|2|4|32) )) = 0'
sh -c 'pylint src/pubtools/exodus; test $(( $? & (1|2|4|32) )) = 0'
black --check .
isort --check .

[testenv:cov]
usedevelop=true
commands=
pytest --cov-report=html --cov=pubtools {posargs}
pytest --cov-report=html --cov=pubtools.exodus {posargs}

[testenv:cov-ci]
passenv=GITHUB_*
usedevelop=true
commands=
pytest --cov=pubtools {posargs}
pytest --cov=pubtools.exodus {posargs}
coveralls --service=github

[testenv:docs]
Expand Down

0 comments on commit ec581e7

Please sign in to comment.