Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various CI fixes for 2023-11 #29

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Various CI fixes for 2023-11 #29

merged 3 commits into from
Nov 14, 2023

Commits on Nov 13, 2023

  1. [ci] fix install of OS packages in CI workflows 

    We should be using "apt-get update" to update package lists before
installing any new packages. This has never mattered before, but
recently the installation of various packages started to fail with
404 errors, which are resolved by updating the package lists first.
    @rohanpm
    rohanpm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a1733be View commit details
    Browse the repository at this point in the history

  2. Manual pre-commit update 

    Manually ran "pre-commit autoupdate". The new version of isort in
particular is necessary to fix install on some newer Python
environments.
    @rohanpm
    rohanpm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ff26b84 View commit details
    Browse the repository at this point in the history

  3. Drop mypy from "tox -e static" 

    mypy started to complain with:

    pubtools/exodus/gateway.py:8: error: Library stubs not installed for "requests.packages.urllib3.util.retry"  [import-untyped]
    pubtools/exodus/gateway.py:8: note: Hint: "python3 -m pip install types-requests"

...despite that types-requests *is* already installed. Other projects
have seen similar issues.

As we do not seem to detect any genuine issues with mypy in practice,
let's drop it from the default CI configuration to reduce the CI
maintenance cost. mypy currently remains in the test-requirements.txt
file to enable running the tool locally.
    @rohanpm
    rohanpm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e01f607 View commit details
    Browse the repository at this point in the history