Introduce Criteria.with_unit_type #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
force-pushed
the
with-unit-type
branch
2 times, most recently
from
9633a76
to
fd41a8d
Compare
It was already possible for callers to search for units of a specific
type by doing, for example:
Criteria.with_field("content_type_id", Matcher.in_(["rpm", "srpm"]))
The problem with this is that it requires the caller to know which
values of content_type_id map to each model class such as RpmUnit.
The library already knows this implementation detail internally and it's
best to avoid duplicating it also in the user of the library.
This commit adds a helper which accepts Unit classes as input, as in:
Criteria.with_unit_type(RpmUnit)
This allows the mapping between unit subclasses and content types to
remain fully encapsulated within this library.
rohanpm
force-pushed
the
with-unit-type
branch
from
fd41a8d
to
f6eebf3
Compare
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 1742 1755 +13
=========================================
+ Hits 1742 1755 +13
Continue to review full report at Codecov.
|
rbikar
approved these changes
Aug 31, 2021
negillett
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already possible for callers to search for units of a specific
type by doing, for example:
The problem with this is that it requires the caller to know which
values of content_type_id map to each model class such as RpmUnit.
The library already knows this implementation detail internally and it's
best to avoid duplicating it also in the user of the library.
This commit adds a helper which accepts Unit classes as input, as in:
This allows the mapping between unit subclasses and content types to
remain fully encapsulated within this library.