Fix authorization failure responses #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages and logging need to be improved for the new authenticated API to troubleshoot issues. Failure to authorize a request with the service must be logged. If permission is denied to post a data (or access an endpoint), 403 Forbidden status code must be returned (currently it is 401). Failure to find user in LDAP should be send back to user (with 403 response including the test case name) In case of LDAP errors, the service should return 502 status code (not 4XX). Return JSON formatted responses consistently. JIRA: RHELWF-10633
hluk
force-pushed
the
fix-authorization
branch
from
93b4f95
to
b9c263d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages and logging need to be improved for the new authenticated API to troubleshoot issues.
Failure to authorize a request with the service must be logged.
If permission is denied to post a data (or access an endpoint), 403 Forbidden status code must be returned (currently it is 401).
Failure to find user in LDAP should be send back to user (with 403 response including the test case name)
In case of LDAP errors, the service should return 502 status code (not 4XX).
Return JSON formatted responses consistently.
JIRA: RHELWF-10633