Supp population sources #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for ubi repositories population from more that one input repo. Repo note 'population_sources' is here used for getting sources, if it's not available, fallback to manual finding of input repositories. This change also refactors usage of 'ubi_population' repo note that enables population of given ubi repositories.
|
run tests |
|
Related to #137 |
negillett
previously approved these changes
Oct 16, 2019
|
run tests |
negillett
approved these changes
Oct 17, 2019
midnightercz
approved these changes
Oct 21, 2019
| def _get_population_sources(self, repo, input_cs): | ||
| src_repos = [] | ||
| if repo.population_sources: | ||
| fts = [self._executor.submit(self.pulp.search_repo_by_id, r) |
There was a problem hiding this comment.
isnt' better to search only once for all the repos in one call?
There was a problem hiding this comment.
it will be refactor within #136
|
|
||
| for in_repo_rpm in self.repos.in_repos.rpm: | ||
| res = self.pulp.search_rpms(in_repo_rpm, filename=rpm_filename) | ||
| if res: |
| self.name = name | ||
| self.filename = filename | ||
| self.sourcerpm_filename = sourcerpm_filename | ||
| self.is_modular = is_modular | ||
| # return name, ver, rel, epoch, arch | ||
| _, self.version, self.release, self.epoch, _ = split_filename(self.filename) | ||
| self.evr_tuple = (self.epoch, self.version, self.release) | ||
| self.associate_source_repo_id = src_repo_id |
There was a problem hiding this comment.
I would rather chose in_repo_id or source_repo_id than associate_source_repo_id. Note that in the future it would make sense to replace this model with pubtools.pulplib.model.unit.rpm.RpmUnit. In the light of that, it would rather make sense to have attribute stating that unit is in some repository not necessarily designed for association
There was a problem hiding this comment.
replacing with pubtools.pulplib.model.unit.rpm.RpmUnit is already planned, so I'll leave it now as it is.
JayZ12138
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for ubi repositories population
from more that one input repo.
Repo note 'population_sources' is here used for
getting sources, if it's not available, fallback
to manual finding of input repositories.
This change also refactors usage of 'ubi_population' repo note
that enables population of given ubi repositories