Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken changelog for windows #130

Closed
Kolobok12309 opened this issue May 24, 2021 · 2 comments · Fixed by #241
Closed

Broken changelog for windows #130

Kolobok12309 opened this issue May 24, 2021 · 2 comments · Fixed by #241

Comments

@Kolobok12309
Copy link

In windows environment i try use release-it-lerna-changelog and my changelogs in release looks something like this and in console this (It's different releases)

�🚀 Let's release release-it-test (currently at 0.0.2)


Changelog:
* Add lerna (bd2d34c)
* Remove lerna (69ad898)
* Update release script (e7bea72)
* Merge pull request #3 from Kolobok12309/feature/second-feature (0adb363)
* Add second console.log (0e182df)

Trouble in shell exec for windows, you try exec command D:\projects\release-it-test\node_modules\lerna-changelog\bin\cli.js --next-version=Unreleased --from=0.0.2, but windows try open *.js file by default viewer, for me it VSCode.
If call node ..., or lerna-changelog --next-version=Unreleased --from=0.0.2 all fine.

@Kolobok12309 Kolobok12309 changed the title Windows commits changelog Broken changelog for windows May 24, 2021
@rwjblue
Copy link
Collaborator

rwjblue commented May 24, 2021

Oh no, you are totally correct! I'm sorry about that.

Hmm, I'm not sure what is the correct way to find the executable in a platform agnostic way?

@Kolobok12309
Copy link
Author

I can not suggest a completely correct option, but lerna-changelog without full path working correctly in windows, npm add node_modules/.bin/lerna-changelog.cmd and use it, for nix it node_modules/.bin/lerna-changelog.

I can help with tests for windows if needed.

patricklx added a commit to patricklx/lerna-changelog that referenced this issue Oct 5, 2022
fixes release-it-plugins#130 

same is also done for git, so why not?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants